It is currently February 4th, 2023, 3:37 am

[Annoyance] Min/Max Warning in 4.5.15.3678

Report bugs with the Rainmeter application and suggest features.
User avatar
SilverAzide
Rainmeter Sage
Posts: 2250
Joined: March 23rd, 2015, 5:26 pm

[Annoyance] Min/Max Warning in 4.5.15.3678

Post by SilverAzide »

Hello!

With the release of Rainmeter 4.5.15.3678, the following change was added:
Measures: In debug mode, display a warning log message when the MinValue and MaxValue are the same or if MaxValue is less than MinValue.
This is a fine enhancement, and it is made better by only being shown when Rainmeter is in debug mode. However, it is annoying in a single scenario: FreeDiskSpace measures.

These measures set MinValue and MaxValue automatically based on the Drive being measured. If the drive is a removable drive that is empty or is a drive that does not exist, MinValue and MaxValue are both set to zero, triggering the warning message.

Code: Select all

WARN (11:13:28.482) Skin\Skin.ini - [MeasureDiskSpaceN]: Warning: MaxValue = MinValue: 0
Even though this message is only displayed while in Debug mode, would it be possible to suppress this message with this particular measure and/or in this particular scenario?
Gadgets Wiki GitHub More Gadgets...
User avatar
killall-q
Posts: 304
Joined: August 14th, 2009, 8:04 am

Re: [Annoyance] Min/Max Warning in 4.5.15.3678

Post by killall-q »

IMO the logic should just be changed so that a warning message is only triggered if MaxValue is less than MinValue, not the same.
User avatar
Brian
Developer
Posts: 2562
Joined: November 24th, 2011, 1:42 am
Location: Utah

Re: [Annoyance] Min/Max Warning in 4.5.15.3678

Post by Brian »

SilverAzide wrote: December 4th, 2022, 11:06 pm Even though this message is only displayed while in Debug mode, would it be possible to suppress this message with this particular measure and/or in this particular scenario?
Good catch. The Min/MaxValue is only manually set in a few instances, so it doesn't make sense to log this message in this case.

Instead of just disabling this message specifically for the FreeDiskSpace measure, I decided to only log the message if either the MinValue or MaxValue option is defined explicitly in the skin. This should not only work for this specific case, but any other cases where the offending measure manually sets the Min/MaxValue.

killall-q wrote: December 5th, 2022, 1:56 am IMO the logic should just be changed so that a warning message is only triggered if MaxValue is less than MinValue, not the same.
It is logged this way since some meters will display nothing at all when both the MinValue and MaxValue are equal to each other. A user might not understand why nothing is displayed. The only indication that something is wrong is in the About dialog/Skins tab where the "Range" will be show something like 0.0 - 0.0 or 1.0 - 1.0 (or whatever the Min/MaxValues are set to). Most users won't see it until Debug mode is turned on.

-Brian
User avatar
SilverAzide
Rainmeter Sage
Posts: 2250
Joined: March 23rd, 2015, 5:26 pm

Re: [Annoyance] Min/Max Warning in 4.5.15.3678

Post by SilverAzide »

Thanks Brian!
Gadgets Wiki GitHub More Gadgets...