It is currently October 1st, 2022, 2:52 pm

4.5.11.3602

Test and provide feedback on potential changes
User avatar
Brian
Developer
Posts: 2512
Joined: November 24th, 2011, 1:42 am
Location: Utah

4.5.11.3602

Post by Brian »

This pre-release build attempts to fix an issue in which certain nested variables would not get evaluated correctly. This happened specifically when an invalid variable name was nested inside another variable.

For example: [MeasureName:Function('[1]')]] where [MeasureName] measure exists, and [1] measure does not exist and is meant to be literal text sent to MeasureName.

Here is the specific topic on the issue: https://forum.rainmeter.net/viewtopic.php?t=39874#p203773

Here is the build: https://builds.rainmeter.net/test_builds/Rainmeter-4.5.11.3598-prerelease.exe ** Edit, newest version here.



Nested variable syntax can be a tricky item to test, so we are asking for your help in testing this build with any skins that utilize nested variable syntax.

Thanks!
-Brian
User avatar
Brian
Developer
Posts: 2512
Joined: November 24th, 2011, 1:42 am
Location: Utah

Re: 4.5.11.3599

Post by Brian »

The previous fix apparently didn't quite fix some of the issues. :oops:


Here is another (hopefully final) test version for this issue.
https://builds.rainmeter.net/test_builds/Rainmeter-4.5.11.3599-prerelease.exe ** Edit, newest version here.

I will leave the previous version up in case people want to test both versions.

Thanks!
-Brian
User avatar
Active Colors
Moderator
Posts: 1184
Joined: February 16th, 2012, 3:32 am
Location: Berlin, Germany

Re: 4.5.11.3599

Post by Active Colors »

I don't have any skins that fall into the special certain cases as in the topic you have linked.
I am just testing my simple skins that simply use variables, nested variables, and 'current index section' technique that you are familiar with.

Version 3598 did not produce any errors and after some testing all my skins worked as intended.

Version 3599 produced errors where it did not suppose to :d
Even though the log was throwing a lot of errors the skins worked as intended.
However, when I was interacting with my skins I noticed some lags when making any action (hovering, clicking, opening context menu, etc.). I think it is probably due to the log being aggressive and writing a lot of entries during every action.

A very simple timer skin:

Code: Select all

[Rainmeter]
Update=1000
AccurateText=1
RightMouseUpAction=[!SkinCustomMenu]
ContextTitle=Start Timer
ContextAction=[!EnableMeasureGroup Timers][!UpdateMeasureGroup Timers]
ContextTitle2=Stop Timer
ContextAction2=[!Refresh]
ContextTitle3=----
ContextAction3=[]
ContextTitle4=Edit Time Values
ContextAction4=["#@#TimeSettings.inc"]
ContextTitle5=----
ContextAction5=[]
ContextTitle6=More actions ...
ContextAction6=[!SkinMenu]


[Metadata]
Name=UVW Timer
Author=Active Colors
Version=1.0
License=Creative Commons Attribution - Non - Commercial - Share Alike 3.0

[Variables]
@include1=#@#TimeSettings.inc

ActionToTake=[Play "#@#Alarm.wav"][!ZPos "2"]

;======================================

[MeasureTimeH]
Measure=Time
Format=%H

[MeasureTimeM]
Measure=Time
Format=%M

[MeasureTimeD]
Measure=Time
Format=%A

;======================================

[MeasureNow]
Measure=Time
Group=Timers
UpdateDivider=-1
Disabled=1

[MeasureTotalSeconds]
Measure=Calc
Group=Timers
Formula=(#TimerHours# * 3600) + (#TimerMinutes# * 60) + #TimerSeconds#
UpdateDivider=-1
Disabled=1

[MeasureTarget]
Measure=Time
Group=Timers
Format=%#m/%#d/%Y %#H:%M:%S
TimeStamp=([MeasureNow:TimeStamp] + [MeasureTotalSeconds])
UpdateDivider=1
Disabled=1
DynamicVariables=1
OnUpdateAction=[!SetVariable Target "[MeasureTarget]"][!UpdateMeasure MeasureLua]

[MeasureLua]
Measure=Script
Group=Timers
ScriptFile=#@#Timer.lua
IfCondition=MeasureLua <= 0
IfTrueAction=#ActionToTake#
Disabled=1

[MeasureHours]
Measure=Calc
Formula=#TimerHours#
RegExpSubstitute=1
Substitute="^(.)$":"0\1"

[MeasureMinutes]
Measure=Calc
Formula=#TimerMinutes#
RegExpSubstitute=1
Substitute="^(.)$":"0\1"

[MeasureSeconds]
Measure=Calc
Formula=#TimerSeconds#
RegExpSubstitute=1
Substitute="^(.)$":"0\1"

;========================

[ObjectBackground]
Meter=Image
ImageName=#@#base.png
X=0
Y=0
W=104
H=104
ScaleMargins=25,25,25,25
AntiAlias=1
DynamicVariables=1
UpdateDivider=-1
LeftMouseUpAction=[PlayStop][!ZPos "0"][!SkinCustomMenu]
MouseActionCursor=0

[ObjectTimer]
Meter=String
MeasureName=MeasureHours
MeasureName2=MeasureMinutes
InlineSetting=Face | Arial
InlineSetting2=Size | 14
InlineSetting3=Weight | 400
InlineSetting4=Color | 35,35,35
StringAlign=CenterCenter
ClipString=0
AntiAlias=1
Hidden=0
DynamicVariables=1
Text=%1:%2
X=(([ObjectBackground:X])+([ObjectBackground:W]/2))
Y=(([ObjectBackground:Y])+([ObjectBackground:H]/2)+1)
NumOfDecimals=0
LeftMouseUpAction=[!EnableMeasureGroup Timers][!UpdateMeasureGroup Timers]
The errors:
Capture.PNG
You do not have the required permissions to view the files attached to this post.
User avatar
Brian
Developer
Posts: 2512
Joined: November 24th, 2011, 1:42 am
Location: Utah

Re: 4.5.11.3599

Post by Brian »

Active Colors wrote: February 4th, 2022, 1:30 pm Version 3599 produced errors where it did not suppose to :d
Even though the log was throwing a lot of errors the skins worked as intended.
However, when I was interacting with my skins I noticed some lags when making any action (hovering, clicking, opening context menu, etc.). I think it is probably due to the log being aggressive and writing a lot of entries during every action.
Yeah, something similar was reported here.

Although I have found the issue, and corrected it...it has also brought up yet another issue from a different piece of code. Hopefully I can get this all sorted out.

Stay tuned...

-Brian
User avatar
Brian
Developer
Posts: 2512
Joined: November 24th, 2011, 1:42 am
Location: Utah

Re: 4.5.11.3602

Post by Brian »

Ok....hopefully this build fixes all the reported issues with nested variable parsing....*fingers crossed*

Here is the test build:
https://builds.rainmeter.net/test_builds/Rainmeter-4.5.11.3602-prerelease.exe


Thanks!
-Brian
User avatar
Active Colors
Moderator
Posts: 1184
Joined: February 16th, 2012, 3:32 am
Location: Berlin, Germany

Re: 4.5.11.3602

Post by Active Colors »

I believe other folks have made more thorough testings, nevertheless, I just wanted to let you know that I haven't faced any issues on my end. Glad you managed to sort it out! Thank you :)
nek
Posts: 65
Joined: November 3rd, 2019, 12:00 am

Re: 4.5.11.3602

Post by nek »

Thank you as always. For now everything works fine.

Code: Select all

> portable installed.
Rainmeter 4.5.11.3602 (64-bit)
Language: English (1033)
Build time: 2022-02-08  0:11:06
Windows 10 Pro 2009 64-bit (build 19043) - Japanese (1041)
Path: Z:\Apps\Rainmeter\
SkinPath: Z:\Apps\Rainmeter\Skins\
SettingsPath: Z:\Apps\Rainmeter\
IniFile: Z:\Apps\Rainmeter\Rainmeter.ini