It is currently December 12th, 2019, 8:31 pm

RainLexer 2.8.0 (syntax highlighter for Notepad++)

Plugins and Addons popular with the Community
User avatar
jsmorley
Developer
Posts: 19864
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

jsmorley » November 27th, 2019, 10:17 pm

Thanks!

I committed the changes to RainLexer and the Rainmeter project files. This is pursuant to what Brian thinks when he gets back on Sunday, as he is the temple guardian of the code, and may have his own thoughts on this.
oZone
Posts: 117
Joined: May 14th, 2018, 4:46 pm

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

oZone » November 28th, 2019, 2:53 pm

jsmorley wrote:
November 27th, 2019, 10:17 pm
Thanks!

I committed the changes to RainLexer and the Rainmeter project files. This is pursuant to what Brian thinks when he gets back on Sunday, as he is the temple guardian of the code, and may have his own thoughts on this.
You're welcome.
Next time I will create seperate thread so I don't go off topic, as this thread is about RainLexer.

But for now, I have noticed few things in source.
Maybe it would be better to remove these lines in Version.h

Code: Select all

#define COMMIT_HASH L"ab72019a"
#define BUILD_TIME L"2019-11-27 17:01:26"
This file UpgradeLog.htm also seems unneeded.

Also I hope that appveyor building will be fixed, as green passing badge is pleasing to the eye :D.
User avatar
jsmorley
Developer
Posts: 19864
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

jsmorley » November 29th, 2019, 1:04 pm

oZone wrote:
November 28th, 2019, 2:53 pm
You're welcome.
Next time I will create seperate thread so I don't go off topic, as this thread is about RainLexer.

But for now, I have noticed few things in source.
Maybe it would be better to remove these lines in Version.h

Code: Select all

#define COMMIT_HASH L"ab72019a"
#define BUILD_TIME L"2019-11-27 17:01:26"
This file UpgradeLog.htm also seems unneeded.

Also I hope that appveyor building will be fixed, as green passing badge is pleasing to the eye :D.
I'm quite sure those lines in Version.h are needed to set the "properties" for the build that are used in About / Version in Rainmeter. I believe they are updated when a build is done, but since they sorta manage themselves, they don't need to be committed every time you build.
oZone
Posts: 117
Joined: May 14th, 2018, 4:46 pm

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

oZone » November 29th, 2019, 2:06 pm

jsmorley wrote:
November 29th, 2019, 1:04 pm
I'm quite sure those lines in Version.h are needed to set the "properties" for the build that are using in About / Version in Rainmeter. I believe they are updated when the build is done, but since they sorta manage themselves, they don't need to be committed every time you build.
I may be wrong but previous versions didn't contain them. I think they are only used in official release.
User avatar
jsmorley
Developer
Posts: 19864
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

jsmorley » November 29th, 2019, 2:08 pm

oZone wrote:
November 29th, 2019, 2:06 pm
I may be wrong but previous versions didn't contain them. I think they are only used in official release.
They are a fairly recent addition, but are used in every beta and final release version, to populate the About / Version panel.


1.png
You do not have the required permissions to view the files attached to this post.
oZone
Posts: 117
Joined: May 14th, 2018, 4:46 pm

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

oZone » November 29th, 2019, 2:18 pm

jsmorley wrote:
November 29th, 2019, 2:08 pm
They are a fairly recent addition, but are used in every beta and final release version, to populate the About / Version panel.
I know but I as I said I still think they are should be only used in official release, because without those line I get build time when I build it and in commit hash I get <local build>.
User avatar
jsmorley
Developer
Posts: 19864
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

jsmorley » November 29th, 2019, 2:34 pm

oZone wrote:
November 29th, 2019, 2:18 pm
I know but I as I said I still think they are should be only used in official release, because without those line I get build time when I build it and in commit hash I get <local build>.
Having the correct build time and commit hash in beta is at least, if not more important, for our end-users than it is in the final release. It clearly defines "when" and "what" the release is based on. It is intended to support official releases we do, and not really for local builds you might do yourself. Both "beta" and "final" releases of Rainmeter are equally "official".

If you use Build.bat to create your own build / installer, it should work as expected. Of course then you need NSIS and all that to create the installer, and you would need your own digital certificate if you want to add digital "signing" to it. Windows is still going to hate your "different" digital signature...

Those entries to Version.h and Version.cs are created/modified in Build.bat. I guess you could edit your local Build.bat to remove those entries to Version.h if you want. If you do that, or if you don't use Build.bat, but just build in Visual Studio, I guess you won't get a valid entry for Commit Hash. About / Version is likely to bark about that.

We are fine with folks creating custom versions of Rainmeter for themselves if they want to mess with the code, but are not particularly happy about those versions ever being distributed in any way. We will do all we can to identify those as "not official, beware!".
User avatar
Brian
Developer
Posts: 1932
Joined: November 24th, 2011, 1:42 am
Location: Utah

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

Brian » December 2nd, 2019, 8:37 am

@oZone:
Thank you for the project file updates, however, we still want to use a specific tools version to indicate VS2019 (which is version 16.0). It is important for all project members to target the same msbuild version in case things get changed from version to version. (I left the .filters tools version at 4.0 since that is what VS2019 still populates a new project file with...even though VS ignores the tools version from .filter files.)

I think the file "UpdateLog.htm" accidentally got committed by Yamajac. I have deleted it.

@jsmorley:
oZone is correct, the COMMIT_HASH and BUILD_TIME macros are created during the build process and should not be committed. Also, the updated revision numbers are also written during the build process and should not be committed as well. (This hasn't come up since we usually do a hard reset after a build. The revision numbers should only be committed on the first beta after a final version. We should probably update the build script.)

-Brian
oZone
Posts: 117
Joined: May 14th, 2018, 4:46 pm

Re: RainLexer 2.6.0 (syntax highlighter for Notepad++)

oZone » December 8th, 2019, 12:33 pm

As I promised in other thread here are some missing options

These should be type 0 keywords

Code: Select all

bothimagecolormatrix1 
bothimagecolormatrix2 
bothimagecolormatrix3 
bothimagecolormatrix4 
bothimagecolormatrix5
bothimagepath
desktopworkareatype
diskquota
header
inputlimit
inputnumber
primarycolormatrix1
primarycolormatrix2
primarycolormatrix3
primarycolormatrix4
primarycolormatrix5
primaryimagepath
secondarycolormatrix1
secondarycolormatrix2
secondarycolormatrix3
secondarycolormatrix4
secondarycolormatrix5
secondaryimagepath
topmost
type 2 and 3 (missing or are in type 0)

Code: Select all

transformstroke
transformstroke=normal
transformstroke=fixed

alias=cpu
alias=gpu
alias=io
alias=ioread
alias=iowrite
alias=ram
alias=ramshared
alias=vram
alias=vramshared

datetype=accessed
datetype=created
datetype=modified

iconsize=extralarge
iconsize=large
iconsize=medium
iconsize=small

playertype=genre
playertype=number

sortdatetype=accessed
sortdatetype=created
sortdatetype=modified

sorttype=date
sorttype=name
sorttype=size
sorttype=type

state=hide
state=maximized
state=minimized
state=show

sysinfotype=adapter_description
sysinfotype=adapter_type
sysinfotype=computer_name
sysinfotype=dns_server
sysinfotype=domain_name
sysinfotype=domainworkgroup
sysinfotype=gateway_address
sysinfotype=host_name
sysinfotype=idle_time
sysinfotype=internet_connectivity
sysinfotype=ip_address
sysinfotype=lan_connectivity
sysinfotype=net_mask
sysinfotype=num_monitors
sysinfotype=os_bits
sysinfotype=os_version
sysinfotype=pagesize
sysinfotype=screen_height
sysinfotype=screen_size
sysinfotype=screen_width
sysinfotype=timezone_bias
sysinfotype=timezone_daylight_bias
sysinfotype=timezone_daylight_name
sysinfotype=timezone_isdst
sysinfotype=timezone_standard_bias
sysinfotype=timezone_standard_name
sysinfotype=user_logontime
sysinfotype=user_name
sysinfotype=virtual_screen_height
sysinfotype=virtual_screen_left
sysinfotype=virtual_screen_top
sysinfotype=virtual_screen_width
sysinfotype=work_area
sysinfotype=work_area_height
sysinfotype=work_area_left
sysinfotype=work_area_top
sysinfotype=work_area_width
also type 2 and 3 but I am not sure
OutputType I don't know if this support other encoding
https://docs.rainmeter.net/manual/plugins/runcommand/#OutputType
PlayerNameWell this can use parent measure name, so it may be bad if it show invalid coloring on it
https://docs.rainmeter.net/manual/measures/nowplaying/#PlayerName

Code: Select all

outputtype=ansi
outputtype=utf16
outputtype=utf8

playername=aimp
playername=cad
playername=itunes
playername=mediamonkey
playername=spotify
playername=winamp
playername=wlm
playername=wmp
already as type 0 but missing as bangs

Code: Select all

autoselectscreen
autoselectscreengroup
btw
These option are deprecated, aren't they? I haven't found any information about them in documetation yet. There may be something in changelog.
And I am lazy to search through source code

Code: Select all

disablerdp
drives
nativetransparency
nettotalspeed
proxy
tablename
trafficvalue
twittertype
User avatar
jsmorley
Developer
Posts: 19864
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: RainLexer 2.8.0 (syntax highlighter for Notepad++)

jsmorley » December 8th, 2019, 2:58 pm

oZone wrote:
December 8th, 2019, 12:33 pm
As I promised in other thread here are some missing options

These should be type 0 keywords

Code: Select all

bothimagecolormatrix1 
bothimagecolormatrix2 
bothimagecolormatrix3 
bothimagecolormatrix4 
bothimagecolormatrix5
bothimagepath
desktopworkareatype
diskquota
header
inputlimit
inputnumber
primarycolormatrix1
primarycolormatrix2
primarycolormatrix3
primarycolormatrix4
primarycolormatrix5
primaryimagepath
secondarycolormatrix1
secondarycolormatrix2
secondarycolormatrix3
secondarycolormatrix4
secondarycolormatrix5
secondaryimagepath
topmost
type 2 and 3 (missing or are in type 0)

Code: Select all

transformstroke
transformstroke=normal
transformstroke=fixed

alias=cpu
alias=gpu
alias=io
alias=ioread
alias=iowrite
alias=ram
alias=ramshared
alias=vram
alias=vramshared

datetype=accessed
datetype=created
datetype=modified

iconsize=extralarge
iconsize=large
iconsize=medium
iconsize=small

playertype=genre
playertype=number

sortdatetype=accessed
sortdatetype=created
sortdatetype=modified

sorttype=date
sorttype=name
sorttype=size
sorttype=type

state=hide
state=maximized
state=minimized
state=show

sysinfotype=adapter_description
sysinfotype=adapter_type
sysinfotype=computer_name
sysinfotype=dns_server
sysinfotype=domain_name
sysinfotype=domainworkgroup
sysinfotype=gateway_address
sysinfotype=host_name
sysinfotype=idle_time
sysinfotype=internet_connectivity
sysinfotype=ip_address
sysinfotype=lan_connectivity
sysinfotype=net_mask
sysinfotype=num_monitors
sysinfotype=os_bits
sysinfotype=os_version
sysinfotype=pagesize
sysinfotype=screen_height
sysinfotype=screen_size
sysinfotype=screen_width
sysinfotype=timezone_bias
sysinfotype=timezone_daylight_bias
sysinfotype=timezone_daylight_name
sysinfotype=timezone_isdst
sysinfotype=timezone_standard_bias
sysinfotype=timezone_standard_name
sysinfotype=user_logontime
sysinfotype=user_name
sysinfotype=virtual_screen_height
sysinfotype=virtual_screen_left
sysinfotype=virtual_screen_top
sysinfotype=virtual_screen_width
sysinfotype=work_area
sysinfotype=work_area_height
sysinfotype=work_area_left
sysinfotype=work_area_top
sysinfotype=work_area_width
Done..

I'm ambivalent about "deprecated" items. I could argue it either way. Since they still work, and in the interests of backwards compatibility, I can argue that they still should be highlighted. In the interest of weaning folks off of them, I could argue they shouldn't. I opted for the more conservative "leave them in" for now, while I chew on it.