!About parameters
Posted: June 28th, 2017, 2:11 pm
Not sure where to put this but wanted to mention that !About is not just limited to the tabname as the manuals say but accepts all the same options as the !Manage bang.
Don't take my word for it.Brian wrote:Hmmm. Not sure what you are seeing, but the !About bang only accepts the tab name as a parameter.
Where the !About bang is invoked:
https://github.com/rainmeter/rainmeter/blob/master/Library/CommandHandler.cpp#L719
Which calls this piece of code: https://github.com/rainmeter/rainmeter/blob/master/Library/DialogAbout.cpp#L63-L85
-Brian
I'm running 4.0 if that helps.Brian wrote:Doesn't work for me. It opens the skins tab correctly, but does not highlight the skin.
-Brian
Doesn't matter what version, the About dialog has never worked this way.Codger wrote:I'm running 4.0 if that helps.
You're good. That's exactly what is going on. Damn, thought I had advanced the cause a tiny bit.Brian wrote:Doesn't matter what version, the About dialog has never worked this way.
What is most likely happening in your case is that you already have the !About dialog open on your desktop with the Skins tab open and some skin selected in the list. Then when you execute the !About Skins ... bang with extra args, it just brings the dialog topmost and 'appears' to have selected the correct skin. But it is an illusion since you had already selected the skin previously. Completely close Rainmeter and try it...it will not work.
Also, there is no error displayed when extra parameters are sent to this bang.
-Brian
Probably not anytime soon since it would take rewriting/redesigning how parameters are sent to the About dialog. It isn't a huge task, just need to think about it carefully to preserve backward-compatibility which is our main priority so that older skins work properly.Codger wrote:Any chance of adding that in the next version?
It's really just an extra click or two on our end so it's not like a big deal. But if the change comes up...Brian wrote:Probably not anytime soon since it would take rewriting/redesigning how parameters are sent to the About dialog. It isn't a huge task, just need to think about it carefully to preserve backward-compatibility which is our main priority so that older skins work properly.
I will definitely keep this on the radar though since it can be helpful while debugging skins.
-Brian