balala wrote: ↑June 15th, 2020, 5:27 pm
Yeah, it might be a little bit too large, but I did it so because I added a lot of features I never saw into a Rainmeter skin. For instance the ability to add events or holidays (by left-, respectively right clicks onto the day you want to add the event to) or the possibility of scrolling the month with the mouse. I tested my skin before I uploaded it and for me didn't take so much CPU usage. I assume on a weaker computer (please don't misunderstand me) this might increase.
Yeah, everybody can decide if want to use my suite or not. I suppose as usually some users are using it, others don't like, don't want or can't use it. Finally it's up to each...
I'm all for the features you added to your skin, I think they're great, but that's not the issue. In my view all this could have been done using way less code and way less CPU (even when idle, not just when adding events). Of course, I wouldn't dare to tell you how to approach things in your skin (so please don't misunderstand me either), but both adding events and scrolling the month(s), could have been achieved easier if the month was a single string meter that you could then tweak it using inline settings on individual days and react on it either using the mouse variables if you only needed click reaction, or a plugin like MouseXY (I saw a mouse plugin in there, not sure if it was the same) if you needed hover reaction as well. Therefore, less code, less CPU usage. Even the way you did it (which is by no means wrong or anything like that), it shouldn't take that amount of resources on idle
(i.e. no animation, no hover, no event or holidays added, etc). Anyway, that's just my take on the whole process from a technical point of view, and that doesn't conflict in any way with my impression that you've done a great job in terms of visuals and functionality / features in your skin(s).
Mino_el_Nukenin wrote: ↑June 15th, 2020, 12:40 pm
So I've just went through both of your skins but it's way too complicated to understand. Too much code and too many fonctions I don't really need... I got lost in all of it.
It may be a bit complicated to understand, yes, but that's inherent to a calendar skin - you have to have a few formulas here and there to handle the particularities of a calendar, you know. I can't speak for balala, but in my example, except probably the spaces before or after the weekdays, there's absolutely nothing that isn't needed for a month calendar to work. In my view, just 375 lines of Rainmeter code (of which a significant part is just repetitive) in a 30 kb ini file isn't that much for a fully functional month calendar skin that can scroll to whatever month in the 1 AD to 9999 AD interval (and that's just because I wanted to limit the year to max 4 digits, LOL).
Bottom line, you'd have to use such sligthly complicated code for a calendar skin, whether you take an already made code like a Lua script and such from some place else, or you do it as an original work. There's no other way when it comes to calendars.