It is currently June 27th, 2019, 11:07 am

Problems with Transformation Matrix Guide

Discussion about the documentation, main Rainmeter site and forums.
User avatar
balala
Rainmeter Sage
Posts: 8320
Joined: October 11th, 2010, 6:27 pm
Location: Gheorgheni, Romania

Problems with Transformation Matrix Guide

balala » April 3rd, 2016, 7:10 pm

These days I worked a lot with the TransformationMatrix option on some image meters and i consulted many times the guide. I think there is a small mistake, which should be fixed.
On the "What the heck is Rainmeter doing?!" section, the formulas of x' and tx are wrong. They should be:
x' = x*a + y*c + 1*tx
tx = x' - x*a - y*c
instead of
x' = x*a + y*b + 1*tx
tx = x' - x*a - y*b
Please check and fix it, if I'm right. Thanks.
User avatar
jsmorley
Developer
Posts: 19273
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: Problems with Transformation Matrix Guide

jsmorley » April 3rd, 2016, 7:12 pm

balala wrote:These days I worked a lot with the TransformationMatrix option on some image meters and i consulted many times the guide. I think there is a small mistake, which should be fixed.
On the "What the heck is Rainmeter doing?!" section, the formulas of x' and tx are wrong. They should be:
x' = x*a + y*c + 1*tx
tx = x' - x*a - y*c
instead of
x' = x*a + y*b + 1*tx
tx = x' - x*a - y*b
Please check and fix it, if I'm right. Thanks.
I'm glad to fix it, but I refuse to dig into TransformationMatirx to check it. If you are quite sure it should be changed, I can take your word for it.

No need to explain, I won't get it anyway... Just "yeah, fix it as I said" if you are sure. ;-)
User avatar
balala
Rainmeter Sage
Posts: 8320
Joined: October 11th, 2010, 6:27 pm
Location: Gheorgheni, Romania

Re: Problems with Transformation Matrix Guide

balala » April 3rd, 2016, 7:17 pm

Yeah, fix it as I said, I'm quite sure. Thanks.
User avatar
jsmorley
Developer
Posts: 19273
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: Problems with Transformation Matrix Guide

jsmorley » April 3rd, 2016, 7:18 pm

balala wrote:Yeah, fix it as I said, I'm quite sure. Thanks.
LOL... Will do. Thanks.
User avatar
jsmorley
Developer
Posts: 19273
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: Problems with Transformation Matrix Guide

jsmorley » April 3rd, 2016, 7:24 pm

Ok, done. Be sure it is correct now. You might have to Shift-refresh.
User avatar
jsmorley
Developer
Posts: 19273
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: Problems with Transformation Matrix Guide

jsmorley » April 3rd, 2016, 7:29 pm

User avatar
balala
Rainmeter Sage
Posts: 8320
Joined: October 11th, 2010, 6:27 pm
Location: Gheorgheni, Romania

Re: Problems with Transformation Matrix Guide

balala » April 3rd, 2016, 7:35 pm

jsmorley wrote:Be sure it is correct now.
It is. Obviously the same fix also should be applied on the link you've posted (https://github.com/rainmeter/rainmeter-docs/commit/abb65ef28173c75989b01ffd290938ddfb447e88)
User avatar
jsmorley
Developer
Posts: 19273
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: Problems with Transformation Matrix Guide

jsmorley » April 3rd, 2016, 7:48 pm

balala wrote:It is. Obviously the same fix also should be applied on the link you've posted (https://github.com/rainmeter/rainmeter-docs/commit/abb65ef28173c75989b01ffd290938ddfb447e88)
The link I posted IS the fix.
User avatar
balala
Rainmeter Sage
Posts: 8320
Joined: October 11th, 2010, 6:27 pm
Location: Gheorgheni, Romania

Re: Problems with Transformation Matrix Guide

balala » April 3rd, 2016, 8:05 pm

jsmorley wrote:The link I posted IS the fix.
When I open it I see both lines: the initial (with red background) and the fixed one (with green). Sorry if i misunderstood something.
User avatar
jsmorley
Developer
Posts: 19273
Joined: April 19th, 2009, 11:02 pm
Location: Fort Hunt, Virginia, USA

Re: Problems with Transformation Matrix Guide

jsmorley » April 4th, 2016, 3:58 am

balala wrote:When I open it I see both lines: the initial (with red background) and the fixed one (with green). Sorry if i misunderstood something.
That is the commit of the change to our repository on GitHub where the documentation is stored. What you are seeing is a "diff", showing the old (red) and new (green) changes.