It is currently October 22nd, 2021, 7:22 am

Skin Packager improvement

Report bugs with the Rainmeter application and suggest features.
User avatar
balala
Rainmeter Sage
Posts: 13337
Joined: October 11th, 2010, 6:27 pm
Location: Gheorgheni, Romania

Re: Skin Packager improvement

Post by balala »

Brian wrote: January 21st, 2021, 6:26 am Sorry for taking so long to respond, I have been a busy with some family medical problems.
Hope everything is alright and all of you are safe and healthy.
Brian wrote: January 21st, 2021, 6:26 am When installing an rmskin, the "Variables files" option works like this:
  • If the skin of the same name has already been installed AND the Advanced > Backup Skins is checked, the entire existing skin (the one previously installed, not the new one) is moved to the @Backup folder.
  • For each file in the "Variables files" field, the file must exist in both the rmskin AND the existing skin (now placed in the @Backups folder).
  • If both files exist, then only the variables that exist in both files will be copied from an existing skin to the newly installed skin.
Here is the code:
https://github.com/rainmeter/rainmeter/blob/master/Library/DialogInstall.cpp#L984-L1007

Basically, the actual variable needs to exist in both the old file and new file in order for it to be "saved" when installing a new skin. It is worth noting that the user can select to NOT backup the skins, which will prevent this option from working as well (although I doubt many use this option).

We don't have any plans on changing this, and I am not sure of any compatibility issues this might cause with older skins if we did decide to change (or add) this. But it looks like you have a work around for now, so that will probably be the best solution for now.
Thanks for the information, that's what I realized myself as well. Ok, I'm gonna do so.
User avatar
Yincognito
Rainmeter Sage
Posts: 4070
Joined: February 27th, 2015, 2:38 pm
Location: Terra Yincognita

Re: Skin Packager improvement

Post by Yincognito »

Brian wrote: January 21st, 2021, 6:26 amSorry for taking so long to respond, I have been a busy with some family medical problems.
We all were, are or will be busy with such problems sooner or later - I was lucky to have it sorted out somewhat satisfactorily at the beginning of last year (thankfully, before the virus). I hope it went out at least as well as it did for me, and good luck and good health to you and your family for the future.
Brian wrote: January 21st, 2021, 6:26 am[*]If both files exist, then only the variables that exist in both files will be copied from an existing skin to the newly installed skin.
[/list]
Yep, I empirically discovered this while trying to help balala (I didn't use the feature myself before), thus why I said to him that "the reason why your original attempt didn't work was that you didn't have any variables in the variables file, so the Skin Packager didn't have any variables whose values it would keep unchanged" in my last reply (balala initially tried to achieve his goal using a variables file with just the name of the section, i.e. [Variables], in it).