[FIXED] Variables files: Variables with an empty value will not be preserved

[raiguard]

While trying to fix some issues related to using the 'Variables files' functionality in my suite, I discovered a bug in the functionality itself: If a variable is blank, like manualHideDisks=, then that value will always be overwritten with the blank, rather than preserving what it might have been set to before the update.

So if the value was set to manualHideDisks=D E, then the user installs a new version that has manualHideDisks= or manualHideDisks="", it will always overwrite the value with the blank, rather than keeping it as manualHideDisks=D E.

I hope that this is an issue that can be fixed. I can redesign the setting to not use a blank value, but it would be very painful and difficult.

To make it absolutely clear, here is a more filled-out example.

Current settings file:

Code: Select all

[Variables]
manualHideDisks=D E
foo=The fox says OWWWWWWW

New settings file:

Code: Select all

[Variables]
manualHideDisks=
foo=bar

Resulting settings file:

Code: Select all

[Variables]
manualHideDisks=
foo=The fox says OWWWWWWW

[jsmorley]

A variable with a blank value is perfectly valid.

[raiguard]

Yes, but if the user had changed it to a non-blank value, then the variables files function will still overwrite it with the blank upon updating.

[jsmorley]

Yes, but if the user had changed it to a non-blank value, then the variables files function will still overwrite it with the blank upon updating.

Well, if you replace Bob with Jim or Bob with a blank, they are both a perfectly valid change.

[jsmorley]

At the end of the day, the "Variables files" functionality in the Advance tab of the .rmskin creator is a binary. If you specify a .inc file, it won't be replaced, so changes the user makes will be preserved. It's the entire file, not "replace this, but not that".

[raiguard]

Sorry, I must not be explaining my issue properly. The reason I discovered this is because a user of my suite complained that his 'manually hidden disks' setting reset upon updating. Click here to view our conversation.

If you want to see it for yourself, download my suite, then go into disks meter's settings skin and hide some disks, and change some other options so it's obviously different from the default. Then go ahead and reinstall that same version again. Theoretically, it should preserve all of your settings. You will find that it preserves everything EXCEPT for which disks you told it to hide.

I'm saying that if the new value is blank, then the system will not overwrite it with the previously set value, instead leaving it blank.

EDIT: Updated explanation to make more sense.

[jsmorley]

If you want to add new variables, but keep changes the user has made to existing variables, you need a second/new .inc file.

[jsmorley]

This may be a bug, I'm not sure. I will ask brian to take a look at it, but I'm not sure when he will be able to get to it.

[raiguard]

Ok, fine with me. In the meantime I'll just have to change how it works to avoid blank values. Thanks for your time.

[raiguard]

Here's a very simple test skin that can be used to test it. The manualHideDisks option will always be reset to blank upon reinstalling, but the other values will be preserved.