Open Hardware Monitor Plugin [11-FEB-2011 V1.1]

[jsmorley]

The "crashes" seem to be related to using a .rmskin to install and load a skin which uses Lua scripting while a OHM skin is running.

If spx looks at this, it should be noted that I am using the new "2.1" version of Rainmeter which is built with C++ 2010 instead of 2008.

[TD22057]

FYI - I sent a PM to spx to see if he can take a look.

[jsmorley]

FYI - I sent a PM to spx to see if he can take a look.

Cool. I'm at the point in my skill with C++ that I would have exactly as much success enhancing how the Hadron Collider works, and that could only turn out really bad for, well... everyone. Everywhere.

[spx]

First, this plugin doesn't work in my system. Shows 0.
OS: XP SP3
OHM: SVN 6-FEB-2011
Rainmeter: 2.0 32bit

Code: Select all

[MeasureSensor3]
Measure=Plugin
Plugin=Plugins\OpenHardwareMonitorPlugin.dll
Hardware=ATI Radeon HD 5700 Series
Type=Temperatures
Sensor=GPU Core
MinValue=0
MaxValue=100
UpdateDivider=5
Debug=1

Error:

Code: Select all

DEBUG: (00:00:00.531) OpenHardwareMonitor: BEGIN: Adding measure 1
   Hardware: 'ATI Radeon HD 5700 Series'
   Type    : 'Temperatures'
   Sensor  : 'GPU Core'
DEBUG: (00:00:00.531) OpenHardwareMonitor: BEGIN: connect
   Sensors: 0
   Read count: 0
DEBUG: (00:00:00.578) OpenHardwareMonitor: END: connect
   Sensors: 34
   Read count: 1
DEBUG: (00:00:00.578) OpenHardwareMonitor: END: Adding measure 1
   No OHM connection active.  Returning.
DEBUG: (00:00:02.156) OpenHardwareMonitor: BEGIN: update sensor values
DEBUG: (00:00:02.156) OpenHardwareMonitor: BEGIN: connect
   Sensors: 34
   Read count: 1
DEBUG: (00:00:02.187) OpenHardwareMonitor: END: connect
   Sensors: 34
   Read count: 2
DEBUG: (00:00:02.187) OpenHardwareMonitor: END: update sensor values
   No OHM connection active.  Returning.
DEBUG: (00:00:02.187) OpenHardwareMonitor: BEGIN: Read measure 1
DEBUG: (00:00:02.187) OpenHardwareMonitor: END: Read measure 1
DEBUG: (00:00:06.187) OpenHardwareMonitor: BEGIN: update sensor values
DEBUG: (00:00:06.187) OpenHardwareMonitor: BEGIN: connect
   Sensors: 34
   Read count: 2
DEBUG: (00:00:06.219) OpenHardwareMonitor: END: connect
   Sensors: 34
   Read count: 3
DEBUG: (00:00:06.234) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:00:06.234) OpenHardwareMonitor: END: update sensor values
DEBUG: (00:00:06.234) OpenHardwareMonitor: BEGIN: Read measure 1
DEBUG: (00:00:06.234) OpenHardwareMonitor: END: Read measure 1

On the other hand, WMI test application (wbemtest.exe) shows correct value.

EDIT:
Commented out SensorMgr.cpp line 368-385, works fine.

Code: Select all

   // If we read the too many or too few of sensors, something changed
   // in the hardware configuration so we need to re-read it.
   //if ( configError || idx < m_sensors.size() )
   //{
   //   log( 0, L"Sensor configuration mismatch found.  Triggering reconfig." );

   //   // Clear the current hardware configuration.
   //   m_connected = false;
   //   m_numSensorRead = 0;
   //   m_sensors.clear();

   //   // Reset the measures.
   //   for ( std::map< UINT, Measure >::iterator i = m_measures.begin();
   //         i != m_measures.end(); ++i )
   //   {
   //      Measure& m = i->second;
   //      m.status = UNCHECKED;
   //      m.idx = 0;
   //   }
   //}

-----

BTW, sensor type is different between OHM GUI and WMI. GUI says "Temperatures", "Voltages", "Fans". However, WMI says "Temerature", "Voltage", "Fan". Which is correct?

[spx]

The "crashes" seem to be related to using a .rmskin to install and load a skin which uses Lua scripting while a OHM skin is running.

Probably fixed in r766.

[jsmorley]

Probably fixed in r766.

Excellent. Thanks.

[TD22057]

First, this plugin doesn't work in my system. Shows 0.
...[removed]

EDIT:
Commented out SensorMgr.cpp line 368-385, works fine.

...[removed]

BTW, sensor type is different between OHM GUI and WMI. GUI says "Temperatures", "Voltages", "Fans". However, WMI says "Temerature", "Voltage", "Fan". Which is correct?

Couple of notes:

Either string for sensor type is fine. The plugin strips trailing 's' from the sensor type so you can use the WMI reported string or the GUI reported string.

That debug output is the correct behavior on startup. The plugin reads the sensor list 3 times before reporting any values. This is to make sure that OHM has time to read all of the hardware which takes a finite amount of time (otherwise the available sensor list is constantly changing). The code you commented out is required as otherwise it will fail if you start changing sensors (turn on/off HDD monitoring) in an already running OHM process.

You may need to just let it initialize for a few (<5) seconds. Then it should start reporting values.

[spx]

Original plugin only logs the following and shows 0 on every update. Is this behavior correct?

Code: Select all

DEBUG: (00:00:51.469) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:00:54.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:00:57.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:00.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:03.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:06.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:09.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:12.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:15.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:18.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:21.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:24.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:27.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:30.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:33.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:36.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:39.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:42.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:45.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:48.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:51.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:54.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:01:57.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:00.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:03.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:06.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:09.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:12.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:15.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:18.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:21.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:24.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:27.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:30.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:33.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:36.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:39.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:42.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:45.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:48.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:51.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:54.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:02:57.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:00.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:03.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:06.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:09.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:12.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:15.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:18.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:21.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:24.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:27.500) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.
DEBUG: (00:03:30.547) OpenHardwareMonitor: Sensor configuration mismatch found.  Triggering reconfig.

EDIT:
I realized what causes it.

Is this OHM's bug? Or isn't "Type=Level"-max 100 ?

[mmoeller]

Sensors of type "Level" should normally not exceed 100%, but you should not rely on that. Anyway, this is a bug in the Open Hardware Monitor. Can you submit a report (File -> Submit Report...) and add a quick note, that there shouldn't be any "remaining life" SMART entry?

[spx]

Sensors of type "Level" should normally not exceed 100%, but you should not rely on that. Anyway, this is a bug in the Open Hardware Monitor. Can you submit a report (File -> Submit Report...) and add a quick note, that there shouldn't be any "remaining life" SMART entry?

Attach the report.

OpenHardwareMonitor.Report.txt.zip

This is not SSD but HDD which has D1 (209) entry, for some reason.